一次创建多个对象并添加到 manytomany 字段

Optimize Serializer's "create" function

keyword:
bulk_create
manytomany.add(list)

Define in a SuperSerializer
The sub serializer inherit create def and get the current model by self.Meta.model
The Model of manytomany field can be retrieve by instance.<manytomany filed name>.model

Create multiple objects and all them to a manytomany fields in one line

  1. This function included SQL in for, which easy to crash when list is too long
  2. Create multiple entries at a time is much more efficient with bulk_create.()

class CommonInfoSerializer(serializers.ModelSerializer):
    class Meta:
        abstract = True

    def create(self, validated_data):
        tags_data = validated_data.pop('tags')
    
        info_model = self.Meta.model
        instance = info_model.objects.create(**validated_data)
        tag_model = instance.tags.model
    
        for tag_data in tags_data:
            tag_name = tag_data.get('name').lower()
            try:
                tag = tag_model.objects.get(name=tag_name)
            except tag_model.DoesNotExist:
                tag = tag_model.objects.create(**tag_data)
                # tag = Tag.objects.create(name=tag_data["name"])
                tag.save()
            instance.tags.add(tag)
    
        return instance

After refactoring:

class CommonInfoSerializer(serializers.ModelSerializer):
    class Meta:
        abstract = True
        
    def create(self, validated_data):
        tags_data = validated_data.pop('tags')
        new_tags = [tag['name'].lower() for tag in tags_data]
    
        info_model = self.Meta.model
        instance = info_model.objects.create(**validated_data)
    
        tag_model = instance.tags.model
        exist_objs = tag_model.objects.filter(name__in=new_tags)                # QuerySet
        exist_tags = list(exist_objs.values_list('name', flat=True))            # List(String)
        to_create_tags = [tag for tag in new_tags if tag not in exist_tags]     # List(String)
        to_create_objs = [tag_model(name='%s' % i) for i in to_create_tags]     # List(Object)
        created_objs = tag_model.objects.bulk_create(to_create_objs)            # List(Object)
        to_add_objs = list(exist_objs) + created_objs                           # List(Object)
        instance.tags.add(*to_add_objs)
        return instance

A roughly test with 8 tags:

Before and after:
165ms vs 461ms

©著作权归作者所有,转载或内容合作请联系作者
平台声明:文章内容(如有图片或视频亦包括在内)由作者上传并发布,文章内容仅代表作者本人观点,简书系信息发布平台,仅提供信息存储服务。

推荐阅读更多精彩内容

  • rljs by sennchi Timeline of History Part One The Cognitiv...
    sennchi阅读 12,129评论 0 10
  • 老人解开领域,将隔界石收了起来:“我叫月势。你是叫何耀天吧。”并扔了一袋子清脆的东西给他,“这是这个世界的货...
    日向凪阅读 1,709评论 0 1
  • 日暮西山满江红,微风瑟瑟入秋冬。漫步人生路,此景甚美暮。且把夕阳作一赋。人生有几何,对酒当高歌。今做他乡客,来日入...
    悠悠流年阅读 7,028评论 0 3
  • 许久未看综艺,被“中餐厅”种草,被赵薇的满瓶柠檬种草。 好看又好喝,就自己动手做咯 ...
    金鱼酱罗斯阅读 1,703评论 0 0
  • 前几天的文章中提到一个姑凉,家里找关系来我们公司做内勤,不到两个月的时间,今天提出了辞职。 同事们瞠目结舌,感慨9...
    梓涵919阅读 1,495评论 0 1